Update module #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circleci: use default node image remove jasmine
set up jest config (@ maps to /example instead of /lib for usage in plugin.js) and init test
|
Anything holding merge back? Do we want to make any changes or updates? |
samtgarson
reviewed
May 30, 2019
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "nuxt-csrf", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
I don't think this package is at 1.0 yet—it would be misleading to suggest it's been battle tested for a stable release.
move configs back to package.json use prototype syntax run lint on test script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @pi0 for the help and @samtgarson for the module.