[dlpierce]

Summary

Asks bundler where gems will go instead of guessing based on ruby version. Fixes git sourced gems not working on nurax where /app/bundle is not used.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

• Test apps are able to start

Detailed Description

Gems are copied from /usr/local/bundle (created by the Dockerfile) to /app/bundle (a compose volume shared between web and worker) to retain them over down/up cycles. This also gives the user ownership of the gem files; sometimes they are root owned, sometimes app. Ownership is important when a gem is installed from a git repo because git will die if there is dubious file ownership.

Nurax deployments do not use the /app/bundle location, causing deploys to fail if a gem is git sourced. This should be fixed now.

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    13 files  ±    0      13 suites  +1   2h 55m 36s ⏱️ + 37m 33s
 7 073 tests +  788   6 767 ✅ +  617  306 💤 +171  0 ❌ ±0 
18 868 runs  +2 060  18 366 ✅ +1 838  502 💤 +222  0 ❌ ±0 

Results for commit a44f1a9. ± Comparison against base commit ee21f39.

This pull request removes 346 and adds 1134 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f233f0467d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f821954a158>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa86463d5d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f233bb55c88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f821a532098>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa866e54ed8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 23148e8c-96c3-4db6-90dc-0b77c97ef1fa
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4c768ec7-77e7-4148-ac41-9c4a6a3230f3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9f5a67f3-f736-490a-a7b8-3eb403718625
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: ee91a21d-9306-4210-b0d6-0cfb2739312d
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6226398c00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8d15c330d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff117741a48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f62263cfca0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8d3252e740>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff11789e120>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 2a873f8c-b56d-4e7c-b855-c67bc78033e6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4ed8d8c3-f6cf-4866-a757-3f321d257c31
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: a4240f37-2530-463d-a274-4d59589ae597
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b72837c0-7631-4c27-992d-0be9eecdb33c
…

[randalldfloyd]

I can still build and up test apps locally with these changes.