Skip to content

Fix duration in millisecond handling - #7369

Merged
kirkkwang merged 1 commit into
mainfrom
fix-duration-in-millisecond-handling
Mar 2, 2026
Merged

kirkkwang merged 1 commit into
mainfrom
fix-duration-in-millisecond-handling

Conversation

@kirkkwang

Copy link
Copy Markdown
Contributor

This commit addresses an issue where durations specified in milliseconds were not being correctly interpreted. The code now checks for values with explicit seconds units (e.g., "25 s") and plain millisecond values (e.g., "120000") and converts them to seconds appropriately. This ensures that durations are accurately represented. I didn't originally catch this because it seems to work fine in the UV on nurax but wasn't working correctly in Hyku.

As a side note, I'm not entirely sure that
the "25 s" format is still an issue with fits but I've added it just in case.

Fixes

This commit addresses an issue where durations specified in milliseconds
were not being correctly interpreted.  The code now checks for values
with explicit seconds units (e.g., "25 s") and plain millisecond values
(e.g., "120000") and converts them to seconds appropriately.  This
ensures that durations are accurately represented.  I didn't originally
catch this because it seems to work fine in the UV on nurax but wasn't
working correctly in Hyku.

As a side note, I'm not entirely sure that
the "25 s" format is still an issue with fits but I've added it just in
case.
@kirkkwang
kirkkwang force-pushed the fix-duration-in-millisecond-handling branch from eb5c5b8 to 015bb39 Compare March 2, 2026 20:31
@github-actions

github-actions Bot commented Mar 2, 2026 •

Copy link
Copy Markdown

Test Results

    13 files  ±0      13 suites  ±0   2h 58m 39s ⏱️ + 1m 1s
 7 075 tests +2   6 769 ✅ +2  306 💤 ±0  0 ❌ ±0 
18 874 runs  +6  18 372 ✅ +6  502 💤 ±0  0 ❌ ±0 

Results for commit 015bb39. ± Comparison against base commit e800622.

This pull request removes 359 and adds 361 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1aafc13358>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f56b17c2d10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb39f6e5280>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1a92a66b80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f56b6d82958>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb39f7035c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 063a614c-ac47-4fb6-b3ee-6bbd04ad9f7c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 5fb198ca-97e3-4c15-a65f-c590765af7ca
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d4a8e967-ba77-4afe-bc1e-d0c2b3bdabae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: f8f3a68c-38a6-4fd6-a4fc-a39bc28092d8
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f005a12d700>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1d9446bb90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1e3d656e10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f005a147bc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1d943e3ad8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1e3d636548>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4f7ed685-f37b-4704-924b-e3badea3e469
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 27597e07-dc0f-4cd7-872a-a6562083cfc1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: f54b51a7-190c-4553-b102-1b5004832519
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 7fb5b9d3-bcfd-4b02-8e21-9cbb39478308
…

♻️ This comment has been updated with latest results.

@kirkkwang
kirkkwang merged commit 8f7f0b5 into main Mar 2, 2026
45 of 47 checks passed
@kirkkwang
kirkkwang deleted the fix-duration-in-millisecond-handling branch March 2, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants