Repository navigation
Fix duration in millisecond handling - #7369
Merged
Merged
Conversation
This commit addresses an issue where durations specified in milliseconds were not being correctly interpreted. The code now checks for values with explicit seconds units (e.g., "25 s") and plain millisecond values (e.g., "120000") and converts them to seconds appropriately. This ensures that durations are accurately represented. I didn't originally catch this because it seems to work fine in the UV on nurax but wasn't working correctly in Hyku. As a side note, I'm not entirely sure that the "25 s" format is still an issue with fits but I've added it just in case.
kirkkwang
force-pushed
the
fix-duration-in-millisecond-handling
branch
from
March 2, 2026 20:31
eb5c5b8 to
015bb39
Compare
Test Results 13 files ±0 13 suites ±0 2h 58m 39s ⏱️ + 1m 1s Results for commit 015bb39. ± Comparison against base commit e800622. This pull request removes 359 and adds 361 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
sjproctor
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where durations specified in milliseconds were not being correctly interpreted. The code now checks for values with explicit seconds units (e.g., "25 s") and plain millisecond values (e.g., "120000") and converts them to seconds appropriately. This ensures that durations are accurately represented. I didn't originally catch this because it seems to work fine in the UV on nurax but wasn't working correctly in Hyku.
As a side note, I'm not entirely sure that
the "25 s" format is still an issue with fits but I've added it just in case.
Fixes