[laritakr]

Creators on admin sets are set in a transaction step, and anything used in the form is overridden
by the transaction step. This change removes the creator requirement from the form, and returns
to previous behavior of allowing the creator to be set in the transaction step.

Fixes

Ref samvera/hyku#2931

Summary

In the past, creator was hidden and just assigned as the user key (email) through the code, but it has to be defined on the object, so it was added into the m3 profile. This requirement caused it to be shown on the form but not actually used because it was being loaded as it always has been.

By updating the m3 profile, it can be renamed on the profile via the name: key (I am using creator_hidden as the renamed term) and then it can be hidden from the form and behave as it did in prior versions.

Additionally, required terms added to the m3 profile via the name: key on the property were not recognized as present in the validator. This issue is addressed as well.

[github-actions]

Test Results

    13 files  ±0      13 suites  ±0   2h 59m 56s ⏱️ + 2m 44s
 7 077 tests +3   6 771 ✅ +4  306 💤 ±0  0 ❌  - 1 
18 880 runs  +6  18 378 ✅ +7  502 💤 ±0  0 ❌  - 1 

Results for commit 4968cc1. ± Comparison against base commit 8f7f0b5.

This pull request removes 366 and adds 369 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4e2c052e50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f769d0c35d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f79472aa8d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4e2c065280>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f769b7499d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f794b048fc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 944c76f1-bddb-4cd7-9b13-d599777d0d04
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 876a10a5-8df1-493f-ad16-f5500ddb8eb4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c987b184-136f-4db6-9a9b-d8a64d6f106f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 2ae4b9a2-e2cf-4a1d-b4fd-ca1cb86521a9
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2c35ac0518>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8f7ba35f18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fdca9df3210>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2c2d5f9ed8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8f7aa5d348>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fdcc8f07e48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 6dbf3403-b2bc-41b0-9a3b-e54c298b84c8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 112ef563-43c2-409e-b265-dd109b0814c8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 907cc815-cbf1-418d-ba81-15e3329d52fe
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 9e20ce3b-d508-4470-af90-efa2440d24de
…

♻️ This comment has been updated with latest results.