-
Couldn't load subscription status.
- Fork 5
patch: Drop support for Python 3.9 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR removes support for Python 3.9 by raising the minimum Python version to 3.10, adds compatibility for Python 3.14, and modernizes code by replacing a long if-elif action dispatch chain with a match-case statement and updating Union type annotations to the newer | syntax. Class diagram for updated _unparse_action method dispatchclassDiagram
class ReverseArgparse {
+_unparse_action(action: Action)
+_unparse_append_action(action: Action)
+_unparse_append_const_action(action: Action)
+_unparse_count_action(action: Action)
+_unparse_extend_action(action: Action)
+_unparse_store_action(action: Action)
+_unparse_store_const_action(action: Action)
+_unparse_store_false_action(action: Action)
+_unparse_store_true_action(action: Action)
+_unparse_sub_parsers_action(action: Action)
+_unparse_boolean_optional_action(action: Action)
}
ReverseArgparse : _unparse_action uses match-case for dispatch
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 93.97% 94.01% +0.03%
==========================================
Files 2 2
Lines 166 167 +1
Branches 37 37
==========================================
+ Hits 156 157 +1
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e8cd4c1 to
ae7d161
Compare
ae7d161 to
b9e5ffb
Compare
Undo the last of 8d15f4a.
Also introduce support for Python 3.14.
Closes #16.
Summary by Sourcery
Drop support for Python 3.9 and add compatibility with Python 3.14 while leveraging modern Python 3.10+ syntax throughout the codebase and updating CI, metadata, and docs accordingly.
New Features:
Enhancements:
X | YsyntaxBuild:
CI:
Documentation:
Tests:
X | Ysyntax instead of Optional or Union