- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
[Snyk] Security upgrade gatsby from 2.32.13 to 5.14.0 #4200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-IP-12704893 - https://snyk.io/vuln/SNYK-JS-IP-12761655 - https://snyk.io/vuln/SNYK-JS-AXIOS-12613773
          Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by addressing critical vulnerabilities. It achieves this by performing a significant version upgrade of the  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR from Snyk upgrades gatsby from v2 to v5. This is a major version jump with significant breaking changes. The current change is incomplete and will break the application as it doesn't update other dependencies like React and Gatsby plugins, which are incompatible with Gatsby v5. A full migration is necessary.
| "author": "Dustin Schau <[email protected]>", | ||
| "dependencies": { | ||
| "gatsby": "^2.0.19", | ||
| "gatsby": "^5.14.0", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading gatsby from major version 2 to 5 will break the project. This is a significant update with many breaking changes that require a broader migration effort.
Here are some of the required changes:
- React Version: Gatsby v5 requires React 18. The 
reactandreact-domdependencies must be upgraded from^16.5.1to^18.0.0. - Gatsby Plugins: All 
gatsby-*plugins are outdated and need to be upgraded to versions compatible with Gatsby v5. For example,gatsby-plugin-sharpis at^2.0.7and should be at^5.13.1or similar. gatsby-image: Thegatsby-imagepackage (^2.0.15) is deprecated and has been replaced bygatsby-plugin-image. This requires not only a dependency change but also code modifications where theImagecomponent is used.StaticQuerycomponent: TheStaticQuerycomponent is deprecated and should be replaced with theuseStaticQueryhook. This will require refactoring theLayoutcomponent.- Dev Dependencies: Development dependencies like 
react-test-renderer(^16.6.0) andbabel-preset-gatsby(^0.1.2) are incompatible and must be updated. 
Simply changing this one line will lead to build failures. I recommend addressing all these migration steps within this PR or creating a dedicated migration PR.
Snyk has created this PR to fix 3 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
examples/using-jest/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-IP-12704893
SNYK-JS-IP-12761655
SNYK-JS-AXIOS-12613773
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Server-side Request Forgery (SSRF)