-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade gatsby from 2.32.13 to 5.14.0 #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-IP-12704893 - https://snyk.io/vuln/SNYK-JS-IP-12761655 - https://snyk.io/vuln/SNYK-JS-AXIOS-12613773
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the project by performing a major version upgrade of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR upgrades Gatsby to v5 to fix security vulnerabilities. However, this is a major breaking change. The other dependencies like Gatsby plugins and React are now incompatible, which will break the project. I've added a critical comment detailing the other dependencies that must be updated and highlighting that code migration will be necessary.
"author": "Nicholas Young <[email protected]>", | ||
"dependencies": { | ||
"gatsby": "^2.0.0", | ||
"gatsby": "^5.14.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading Gatsby from v2 to v5 is a major breaking change. While this fixes the security vulnerabilities, it will break the example project because other dependencies are now incompatible.
To make this upgrade work, several other packages need to be updated as well. Here's a list of required changes:
gatsby-plugin-sitemap
:^2.0.1
->^5.14.0
gatsby-source-filesystem
:^2.0.1
->^5.14.0
gatsby-transformer-remark
:^2.1.1
->^5.14.0
react
:^16.3.2
->^18.2.0
react-dom
:^16.3.2
->^18.2.0
Furthermore, this major version jump comes with significant API changes. Files such as gatsby-config.js
and gatsby-node.js
will likely need to be migrated to the new APIs to prevent build failures.
Snyk has created this PR to fix 3 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
examples/sitemap/package.json
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-IP-12704893
SNYK-JS-IP-12761655
SNYK-JS-AXIOS-12613773
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Server-side Request Forgery (SSRF)