Skip to content

Making dot qualified expression configurable - #1420

Open
orchestr7 wants to merge 9 commits into
masterfrom
bugfix/configurable-dot-qualified
Open

Making dot qualified expression configurable#1420
orchestr7 wants to merge 9 commits into
masterfrom
bugfix/configurable-dot-qualified

Conversation

@orchestr7

Copy link
Copy Markdown
Member

What's done:

  • now dot qualified expression will be configured with 'maxCallsInOneLine' again

### What's done:
- now dot qualified expression will be configured with 'maxCallsInOneLine' again
@github-actions

github-actions Bot commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 269 tests   1 253 ✔️  1m 2s ⏱️
   154 suites       15 💤
   154 files           1

For more details on these failures, see this check.

Results for commit e39843c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 269 tests   1 253 ✔️  38s ⏱️
   154 suites       15 💤
   154 files           1

For more details on these failures, see this check.

Results for commit e39843c.

♻️ This comment has been updated with latest results.

@petertrr petertrr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay as another quick fix for this; we've opened #1412 to merge two overlapping parts of logic (after 1.2.2 probably)

@petertrr petertrr added this to the 1.2.2 milestone Jul 5, 2022
# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 027 tests  +1   2 012 ✔️ +1   21m 2s ⏱️ + 3m 45s
   166 suites ±0        15 💤 ±0 
   166 files   ±0          0 ±0 

Results for commit 3fb2d7c. ± Comparison against base commit 3a0cc50.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   25m 47s ⏱️ -46s
2 027 tests +1  1 989 ✔️ +1  34 💤 ±0  4 ±0 
2 031 runs  +1  1 993 ✔️ +1  34 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit 3fb2d7c. ± Comparison against base commit 3a0cc50.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Mar 20, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.50%. Comparing base (3a0cc50) to head (3fb2d7c).
⚠️ Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt 89.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1420   +/-   ##
=========================================
  Coverage     82.50%   82.50%           
- Complexity     2335     2336    +1     
=========================================
  Files           112      112           
  Lines          7892     7893    +1     
  Branches       2048     2048           
=========================================
+ Hits           6511     6512    +1     
  Misses          452      452           
  Partials        929      929           
Flag Coverage Δ
unittests 82.50% <89.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orchestr7

Copy link
Copy Markdown
Member Author

@nulls thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants