Skip to content

test: add unformatted PHP to trigger transformer#1

Open
sawez-deepsource wants to merge 5 commits intomasterfrom
test/trigger-transformer-logs
Open

test: add unformatted PHP to trigger transformer#1
sawez-deepsource wants to merge 5 commits intomasterfrom
test/trigger-transformer-logs

Conversation

@sawez-deepsource
Copy link
Copy Markdown
Owner

Summary

  • Adds an intentionally unformatted PHP file to trigger the transformer/formatter pipeline
  • Used for observing transformer logs in GCP

Test plan

  • Verify transformer runs on this PR
  • Check GCP logs for transformer output

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Mar 23, 2026

DeepSource Code Review

We reviewed changes in 21e5e1d...e75fda1 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Mar 23, 2026 6:28a.m. Review ↗

@deepsource-development
Copy link
Copy Markdown

deepsource-development bot commented Mar 23, 2026

DeepSource Code Review

We reviewed changes in 21e5e1d...e75fda1 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Mar 23, 2026 6:28a.m. Review ↗

sawez-deepsource and others added 2 commits March 23, 2026 11:55
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit fixes the style issues introduced in a902146 according to the output
from PHP CS Fixer.

Details: #1

private function handleGet( $path, $params )
{
$cacheKey='get_'.md5( $path.serialize($params) );
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of insecure md5() function found


Using md5(), sha1() function is not recommended to generate secure passwords. Due to its fast nature to compute passwords too quickly, these functions can become really easy to crack a password using brute force attack.

It is recommended to use PHP's password hashing function password_hash() to create a secure password hash.

return empty( $this->errors );
}

private function validateRequired( $field, $value, $params )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateRequired() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMin( $field, $value, $params )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMin() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMax( $field, $value, $params )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMax() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateEmail( $field, $value, $params )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateEmail() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateNumeric( $field, $value, $params )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateNumeric() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateIn($field,$value,$params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateIn() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.


private function handleGet($path, $params)
{
$cacheKey = 'get_'.md5($path.serialize($params));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of insecure md5() function found


Using md5(), sha1() function is not recommended to generate secure passwords. Due to its fast nature to compute passwords too quickly, these functions can become really easy to crack a password using brute force attack.

It is recommended to use PHP's password hashing function password_hash() to create a secure password hash.

return empty($this->errors);
}

private function validateRequired($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateRequired() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMin($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMin() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMax($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMax() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateEmail($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateEmail() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateNumeric($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateNumeric() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateIn($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateIn() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

sawez-deepsource and others added 2 commits March 23, 2026 11:58
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit fixes the style issues introduced in d21b458 according to the output
from PHP CS Fixer.

Details: #1

private function handleGet($path, $params)
{
$cacheKey = 'get_'.md5($path.serialize($params));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of insecure md5() function found


Using md5(), sha1() function is not recommended to generate secure passwords. Due to its fast nature to compute passwords too quickly, these functions can become really easy to crack a password using brute force attack.

It is recommended to use PHP's password hashing function password_hash() to create a secure password hash.

return empty($this->errors);
}

private function validateRequired($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateRequired() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMin($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMin() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateMax($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateMax() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateEmail($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateEmail() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateNumeric($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateNumeric() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.

}
}

private function validateIn($field, $value, $params)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private method validateIn() is not used


The class contains unused private methods. These private class methods are dead code, and do nothing. It is recommended to remove these unused private methods.

It is also recommended that you review these unused private methods if they were added for later use in the code, but the author missed using them.


class EventRepository
{
private $events = [];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private property $events is not used


The class contains unused private property. These private class properties should be removed as they can sometimes lead to confusion while reading the code.

It is also recommended that you review these unused private properties, in case they were added for later use in the code, but the author missed using them.


class EventRepository
{
private $events = [];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private property $events is not used


The class contains unused private property. These private class properties should be removed as they can sometimes lead to confusion while reading the code.

It is also recommended that you review these unused private properties, in case they were added for later use in the code, but the author missed using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant