fix: declare sync_every and sync_every_tasks as class attributes, not properties - #217
Merged
kodiakhq[bot] merged 1 commit intoMar 11, 2026
Conversation
… properties
In celery's source (celery/beat.py), `sync_every` and `sync_every_tasks`
are plain class attributes (lines 242-245), not properties:
class Scheduler:
sync_every = 3 * 60
sync_every_tasks = None
Declaring them as @Property in the stubs causes pyright
reportAssignmentType errors when subclasses override them as class
variables, which is the intended usage pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduler.sync_everyandScheduler.sync_every_tasksare declared as@propertyincelery-stubs/beat.pyi, but in celery's source code (celery/beat.pylines 242-245) they are plain class attributes:This causes
reportAssignmentTypeerrors in pyright when subclasses override them as class variables, which is the intended usage pattern:Fix
Changed both from
@propertyto plain class attribute declarations:Related: #216