is_aborted does not require task_id - #225
Merged
Merged
Conversation
jgarst
force-pushed
the
jgarst/is-aborted-signature
branch
from
June 23, 2026 02:07
bf8d1c3 to
321c2e7
Compare
jgarst
force-pushed
the
jgarst/is-aborted-signature
branch
from
June 23, 2026 02:11
321c2e7 to
405b88a
Compare
Contributor
Author
|
Apologies for the failed test run, I missed some linters. I see everything as passing locally now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_abortedmethod accepts either no arguments, or a single argument to override thetask_idthat is being checked. The current type signature correctly describes the second case but not the first.https://github.com/celery/celery/blob/aef7f130e3ca547c49d3d581a831927458fc1a71/celery/contrib/abortable.py#L147
This is kind of a drive by contribution - I've tried to copy the current testing style, let me know if there are any other conventions that I should be following.