Skip to content

doctool: propagate errors from inspectAllTastyFiles #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: lts-3.3
Choose a base branch
from
Open

doctool: propagate errors from inspectAllTastyFiles #495

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc6ad01
doctool: propagate errors from inspectAllTastyFiles
katrinafyi Jul 23, 2025
7d29893
improve tasty failure message
katrinafyi Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scaladoc/src/dotty/tools/scaladoc/tasty/TastyParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,9 @@ object ScaladocTastyInspector:
report.error("File extension is not `tasty` or `jar`: " + invalidPath)

if tastyPaths.nonEmpty then
TastyInspector.inspectAllTastyFiles(tastyPaths, jarPaths, classpath)(inspector)
val tastyOk = TastyInspector.inspectAllTastyFiles(tastyPaths, jarPaths, classpath)(inspector)
if !tastyOk then
report.error("Failure")

val all = inspector.topLevels.result()
all.groupBy(_._1).map { case (pckName, members) =>
Expand Down