Skip to content

Improve use of boolean defaults #23564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jul 18, 2025

A couple of cases where recursing with default booleans was especially confusing.

Spellcheck would like to change booleans to beanpoles.

I know the project hates so-called style PRs.

But if I see something morally wrong, I cannot but act upon it.

I must confirm that inlined helper such as jsig1 allows tailrec. Maybe it's enough to annotate jsig? Edit: I see goto 0 only. With tailrec, it complains about the RHS of the helper inline def jsig1, which is spurious.

@som-snytt som-snytt marked this pull request as ready for review July 19, 2025 17:23
@tgodzik tgodzik self-requested a review July 21, 2025 09:16
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense

@tgodzik tgodzik merged commit 3770ee8 into scala:main Jul 21, 2025
29 checks passed
@som-snytt som-snytt deleted the tweak/boolean-usage branch July 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants