Make SIP-62 better-fors a stable feature
#23630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
added
release-notes
WojciechMazur
commented
Jul 29, 2025
| @@ -43,7 +43,7 @@ enum SourceVersion: | |||
| def enablesClauseInterleaving = isAtLeast(`3.6`) | |||
| def enablesNewGivens = isAtLeast(`3.6`) | |||
| def enablesNamedTuples = isAtLeast(`3.7`) | |||
| def enablesBetterFors(using Context) = isAtLeast(`3.7`) && isPreviewEnabled | |||
| def enablesBetterFors = isAtLeast(`3.8`) | |||
There was a problem hiding this comment.
I wonder should we also enable it under -source:3.7, -preview - it makes sense to me as well
Suggested change
| def enablesBetterFors = isAtLeast(`3.8`) | |
| def enablesBetterFors(using Context) = isAtLeast(`3.8`) || ( isAtLeast(`3.7`) && isPreviewEnabled) |
WojciechMazur
force-pushed
the
stable/better-fors
branch
from
5e7cc92 to
34e2162
Compare
Gedochao
approved these changes
Jul 31, 2025
KacperFKorban
approved these changes
Jul 31, 2025
|
@WojciechMazur I think that you may have forgotten to accept your change from #23630 (comment) |
KacperFKorban
pushed a commit
that referenced
this pull request
Jul 31, 2025
Addendum to #23630 with missing adjustment for older source verisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.