- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
Warn if type argument was inferred as union type #24258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +55
        
        
          −1
        
        
          
        
      
    
  
  
     Merged
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package dotty.tools.dotc.transform | ||
|  | ||
| import dotty.tools.dotc.ast.tpd | ||
| import dotty.tools.dotc.ast.tpd.InferredTypeTree | ||
| import dotty.tools.dotc.core.Contexts.{Context, ctx} | ||
| import dotty.tools.dotc.core.Decorators.em | ||
| import dotty.tools.dotc.core.Types.OrType | ||
| import dotty.tools.dotc.report | ||
| import dotty.tools.dotc.transform.MegaPhase.MiniPhase | ||
|  | ||
| class WInferUnion extends MiniPhase { | ||
|  | ||
| override def phaseName: String = WInferUnion.name | ||
|  | ||
| override def description: String = WInferUnion.description | ||
|  | ||
| override def isEnabled(using Context): Boolean = ctx.settings.Whas.inferUnion | ||
|  | ||
| override def transformTypeApply(tree: tpd.TypeApply)(using Context): tpd.Tree = | ||
| val inferredOrTypes = tree.args.find: tpt => | ||
| tpt.isInstanceOf[InferredTypeTree] && tpt.tpe.stripTypeVar.isInstanceOf[OrType] | ||
| inferredOrTypes.foreach: tpt => | ||
| report.warning( | ||
| em"""|A type argument was inferred to be union type ${tpt.tpe.stripTypeVar} | ||
| |This may indicate a programming error. | ||
| |""", tpt.srcPos) | ||
| tree | ||
| } | ||
|  | ||
| object WInferUnion: | ||
| val name = "Winfer-union" | ||
| val description = "check for type arguments inferred as union types" | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| -- Warning: tests/warn/infer-or-type.scala:6:18 ------------------------------------------------------------------------ | ||
| 6 | val _ = List(1).contains("") // warn | ||
| | ^^^^^^^^^^^^^^^^ | ||
| | A type argument was inferred to be union type Int | String | ||
| | This may indicate a programming error. | ||
| -- Warning: tests/warn/infer-or-type.scala:7:10 ------------------------------------------------------------------------ | ||
| 7 | val _ = Pair(1, "") // warn | ||
| | ^^^^ | ||
| | A type argument was inferred to be union type Int | String | ||
| | This may indicate a programming error. | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| //> using options -Winfer-union | ||
|  | ||
| case class Pair[A](x: A, y: A) | ||
|  | ||
| def test = { | ||
| val _ = List(1).contains("") // warn | ||
| val _ = Pair(1, "") // warn | ||
| } | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.