-
Notifications
You must be signed in to change notification settings - Fork 39
Add transaction mode support for data export in dataloader core and CLI #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 25 commits
da1cb57
29ca31b
8ea08fa
5042c49
e4db961
7b91326
9ad1219
7ab8b65
b3414fb
e32fd44
24ce20c
68059f8
eb62e60
f4b0571
735c47e
43ef7bc
7c15643
a53757b
cbba68c
1c62a14
72d5907
a3ae85e
c20b183
303b288
37fa8af
8c189e8
36f9b43
374e833
39a4abd
761deca
9fe9c83
d45f4cd
ed66ab1
2138113
b9cbd6b
c2192da
42bc80f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import com.scalar.db.api.Scan; | ||
import com.scalar.db.dataloader.core.ColumnKeyValue; | ||
import com.scalar.db.dataloader.core.FileFormat; | ||
import com.scalar.db.dataloader.core.ScalarDbMode; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
import picocli.CommandLine; | ||
|
@@ -144,4 +145,11 @@ public class ExportCommandOptions { | |
description = "Size of the data chunk to process in a single task (default: 200)", | ||
defaultValue = "200") | ||
protected int dataChunkSize; | ||
|
||
@CommandLine.Option( | ||
names = {"--mode", "-sm"}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @brfrn169 san,
I didn't want to change the existing value as it has been there from the always and there may be users who use it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @brfrn169 san, |
||
description = "ScalarDB mode (STORAGE, TRANSACTION) (default: STORAGE)", | ||
paramLabel = "<MODE>", | ||
defaultValue = "STORAGE") | ||
protected ScalarDbMode scalarDbMode; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to consider #2740 (comment) ?