-
Notifications
You must be signed in to change notification settings - Fork 39
Fix for exclude CSV header option not working #2924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @inv-jishnu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the data loader CLI where the option to exclude CSV headers during data export was not functioning as intended. The fix involves a targeted code change to ensure the header is only written when explicitly required, complemented by new unit tests to validate the corrected behavior for both header inclusion and exclusion.
Highlights
- Bug Fix: Resolved an issue where the
--no-header
option in the data loader CLI's CSV export functionality was not correctly excluding the header row from the output file, leading to unintended header inclusion. - Conditional Logic Update: Implemented a conditional check within the
processHeader
method ofCsvExportManager.java
to prevent the CSV header from being written to the output file when theexcludeHeaderRow
option is enabled. - Enhanced Test Coverage: Added new unit tests in
CsvExportManagerTest.java
to explicitly verify the correct behavior of CSV exports, covering both scenarios where the header is expected to be included and excluded. A new helper method,runExportAndAssertFirstLine
, was introduced to streamline these tests.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where the --no-header
option was not working for CSV exports. Unit tests cover both header inclusion and exclusion. The review includes suggestions to enhance the robustness and readability of the new test code, and a minor efficiency improvement in the core logic.
Description
The option to exclude header (--no-header on CLI) from CSV file when creating an
export
through data loader CLI was not working as expected. Even when this option was enabled the header was being written to the CSV file. This occurred I believe as the CSV header write part was moved as part of splitting ExportManager class, the check for excluding header row not added (My apologies as I missed to add that). I have fixed that in this PR.Related issues and/or PRs
NA
Changes made
I have added a check to before writing the CSV Header part to see if header is excluded is export options. I have also added few unit tests to confirm both cases, header included and excluded.
Checklist
Additional notes (optional)
NA
Release notes
Fixed issue of exclude header or
--no-header
not working on data loader when these are enabled.