Skip to content

test(mongodb): regroup tests #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jul 24, 2025

…ed tests

@jremy42 jremy42 requested a review from remyleone as a code owner July 24, 2025 14:43
@jremy42 jremy42 force-pushed the feat/refacto_mongodb_test branch from 4fd95cb to 824bdb8 Compare July 24, 2025 15:07
@remyleone remyleone changed the title test(mongodb): regroup acceptance tests for each resource into unifi… test(mongodb): regroup tests Jul 24, 2025
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@@ -13,7 +13,7 @@ import (
"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/mongodb"
)

func TestAccMongoDBInstance_Basic(t *testing.T) {
func TestAccMongoDBInstance_CombinedBasicUpdate(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a change of name in necessary

@jremy42 jremy42 force-pushed the feat/refacto_mongodb_test branch 2 times, most recently from a861aa3 to 855e2b7 Compare July 25, 2025 07:53
@jremy42 jremy42 force-pushed the feat/refacto_mongodb_test branch from 855e2b7 to 2b80ecb Compare July 25, 2025 08:26
@jremy42 jremy42 self-assigned this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants