Skip to content

Conversation

williamlardier
Copy link
Contributor

For Veeam reoutes, this will set 0 as the metric. The value is correct: if scuba returns a 404 error, it means there is no metric for the resource.

Issue: CLDSRV-758

For Veeam reoutes, this will set 0 as the metric. The value is
correct: if scuba returns a 404 error, it means there is no
metric for the resource.

Issue: CLDSRV-758
@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 13, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-758 contains:

  • 9.0.31

  • 9.1.5

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.5

Please check the Fix Version/s of CLDSRV-758, or the target
branch of this pull request.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (a8d5672) to head (9c665d1).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/veeam/get.js 97.29% <100.00%> (+9.79%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.1    #5968      +/-   ##
===================================================
+ Coverage            83.72%   84.00%   +0.27%     
===================================================
  Files                  191      191              
  Lines                12233    12238       +5     
===================================================
+ Hits                 10242    10280      +38     
+ Misses                1991     1958      -33     
Flag Coverage Δ
ceph-backend-test 64.58% <0.00%> (-0.02%) ⬇️
file-ft-tests 66.90% <0.00%> (-0.03%) ⬇️
kmip-ft-tests 27.18% <0.00%> (-0.02%) ⬇️
mongo-v0-ft-tests 68.21% <0.00%> (-0.05%) ⬇️
mongo-v1-ft-tests 68.22% <0.00%> (-0.03%) ⬇️
multiple-backend 34.23% <0.00%> (-0.02%) ⬇️
sur-tests 34.77% <0.00%> (-0.87%) ⬇️
sur-tests-inflights 36.70% <0.00%> (-0.05%) ⬇️
unit 69.32% <100.00%> (+0.99%) ⬆️
utapi-v2-tests 33.56% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants