Edited for including n_shadow_features #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request addresses issue number #142 from April 19, 2025, which adds support for a' n_shadow_features' parameter in BorutaPy, allowing users to control how many shadow features are generated during feature selection.
Motivation
In some datasets with a very high number of features, creating one shadow per real feature can be expensive and unnecessary. This feature allows greater control and flexibility.
Details
Adds n_shadow_features to init
Modifies _add_shadows_get_imps and _fit logic accordingly
Ensures backward compatibility with the original behavior
Includes a unit test for this feature