Skip to content

Spelling - #49

Merged
quentinhaenn merged 10 commits into
scikit-learn-contrib:mainfrom
jsoref:spelling
Dec 17, 2025
Merged

quentinhaenn merged 10 commits into
scikit-learn-contrib:mainfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Description

This PR corrects misspellings identified by the check-spelling action

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The misspellings have been reported at https://github.com/jsoref/radius_clustering/actions/runs/19397924269/attempts/1#summary-55500676293

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/radius_clustering/actions/runs/19397924378/attempts/1#summary-55500676477

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@bchardin

Copy link
Copy Markdown
Collaborator

For the neibor to neighbor typo correction, this is part of the EMOS source code. I believe there's no real downside in having our code differ from theirs, since the original source code does not seem to be maintained.
@quentinhaenn: what do you think?

Comment thread src/radius_clustering/utils/main-emos.c
@quentinhaenn

Copy link
Copy Markdown
Collaborator

I agree, since the authors are still cited and their initial idea still acknowledge.

@quentinhaenn quentinhaenn self-assigned this Dec 17, 2025
@quentinhaenn quentinhaenn added the documentation Improvements or additions to documentation label Dec 17, 2025
@quentinhaenn
quentinhaenn merged commit 4ed6aef into scikit-learn-contrib:main Dec 17, 2025
@jsoref
jsoref deleted the spelling branch December 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants