test(sshfs,scp): create files on the fly to work around Windows filesystem #1408
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
scp-refactor-1-4
branch
from
e8aeed7 to
e238dde
Compare
akinomyoga
changed the title
scop
reviewed
Aug 7, 2025
There was a problem hiding this comment.
Should we not remove the test/fixtures/sshfs dir and its contents as part of this change? It would seem to be unused after this, and would still cause problems if around I guess.
There was a problem hiding this comment.
Ah, right. I completely forgot that. I'll address it.
There was a problem hiding this comment.
akinomyoga
force-pushed
the
scp-refactor-1-4
branch
from
e238dde to
3c07ffd
Compare
akinomyoga
force-pushed
the
scp-refactor-1-4
branch
from
3c07ffd to
8841957
Compare
The test has not been prepared because the ending spaces cannot be tested with the typical comparison of `completion == "..."` or `completion == [...]`, but it turned out that existing test cases uses `completion.output` to check suffixing spaces. This patch implements the test using `completion.output`. scop#1397 (comment)
akinomyoga
force-pushed
the
scp-refactor-1-4
branch
from
8841957 to
c3d122a
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the remaining issue with PR 1397, #1397 (comment).
e8aeed7 Also, the second commit adds tests for the regression of PR 1397 with the
scpcommand, which was not added in PR 1397 because I thought it could not be tested. As commented in #1397 (comment), it was actually possible. I'm adding tests usingcompletion.outputin this patch.