-
Notifications
You must be signed in to change notification settings - Fork 156
Fix-product_scraping #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflict first, and it doesn't pass the product data is empty:
"rate": null,
"reviews": null,
"soldCount": 0,
"availableCount": null
},
"pricing": {
"priceCurrency": "USD $",
"price": null,
"originalPrice": "No discount",
"discount": "No discount"
},
"specifications": [],
"shipping": {
"cost": null,
"currency": "$",
"delivery": null
},
"faqs": [],
"seller": {
"name": null,
"link": null,
"id": null,
"info": {
"positiveFeedback": null,
"followers": null
}
},
also why did you remove the cookie for the localization settings, it's good to have it to control the localization since the domain is available in different countries. If it's outdated, we should updated but not remove it
Are you sure you don't have cache enabled? Because I checked the request and it's actually blocked: could you share you request log for that successful run? the log for "retrieving a session ID" here is redundant: async def scrape_product(url: str) -> List[Product]:
"""scrape aliexpress products by id"""
log.info("retrieving a session ID")
log.info("scraping product: {}", url) and the PR still has conflicts |
This reverts commit b6e027b.
…ry information fallback
@mazen-r |
No description provided.