Skip to content

Refactor StudioTabNav to use useRouteMatch #9850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactor StudioTabNav to use useRouteMatch #9850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 42 additions & 42 deletions src/views/studio/studio-tab-nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, {useCallback} from 'react';
import React from 'react';
import PropTypes from 'prop-types';
import {connect} from 'react-redux';
import {useParams, NavLink} from 'react-router-dom';
import {useRouteMatch, NavLink} from 'react-router-dom';
import {FormattedMessage} from 'react-intl';

import SubNavigation from '../../components/subnavigation/subnavigation.jsx';
Expand Down Expand Up @@ -40,67 +40,67 @@ const countLimits = {
};

const StudioTabNav = ({isFetchingInfo, commentCount, projectCount}) => {
const {studioPath, studioId} = useParams();
const {params: {studioPath, studioId}} = useRouteMatch();
const base = `/${studioPath}/${studioId}`;
const classes = useCallback(({isActive}) => `nav_link ${isActive ? 'active' : ''}`);
return (
<SubNavigation
align="left"
className="studio-tab-nav"
>
<NavLink
className={classes}
activeClassName="active"
className="nav_link"
to={base}
exact
>
<li>
<img src={projectsIcon} />
<FormattedMessage
id={isFetchingInfo ? 'studio.tabNavProjects' : 'studio.tabNavProjectsWithCount'}
values={{
projectCount: (
<span className="tab-count">
({limitCount(projectCount, countLimits.projects)})
</span>
)
}}
/>
</li>
<li><img
src={projectsIcon}
/><FormattedMessage
id={isFetchingInfo ? 'studio.tabNavProjects' : 'studio.tabNavProjectsWithCount'}
values={{
projectCount: (
<span className="tab-count">
({limitCount(projectCount, countLimits.projects)})
</span>
)
}}
/></li>
</NavLink>
<NavLink
className={classes}
activeClassName="active"
className="nav_link"
to={`${base}/comments`}
>
<li>
<img src={commentsIcon} />
<FormattedMessage
id={isFetchingInfo ? 'studio.tabNavComments' : 'studio.tabNavCommentsWithCount'}
values={{
commentCount: (
<span className="tab-count">
({limitCount(commentCount, countLimits.comments)})
</span>
)
}}
/>
</li>
<li><img
src={commentsIcon}
/><FormattedMessage
id={isFetchingInfo ? 'studio.tabNavComments' : 'studio.tabNavCommentsWithCount'}
values={{
commentCount: (
<span className="tab-count">
({limitCount(commentCount, countLimits.comments)})
</span>
)
}}
/></li>
</NavLink>
<NavLink
className={classes}
activeClassName="active"
className="nav_link"
to={`${base}/curators`}
>
<li>
<img src={curatorsIcon} />
<FormattedMessage id="studio.tabNavCurators" />
</li>
<li><img
src={curatorsIcon}
/><FormattedMessage id="studio.tabNavCurators" /></li>
</NavLink>
<NavLink
className={classes}
activeClassName="active"
className="nav_link"
to={`${base}/activity`}
>
<li>
<img src={activityIcon} />
<FormattedMessage id="studio.tabNavActivity" />
</li>
<li><img
src={activityIcon}
/><FormattedMessage id="studio.tabNavActivity" /></li>
</NavLink>
</SubNavigation>
);
Expand Down