INTEGRITY: Continuing set.dat's processing #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivangNagta
changed the title
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
93d01e2 to
1fee585
Compare
…echecksum. Add new equal checksums for set.dat's fileset match
…rtial in the same run.
…modification time
…which is never closed.
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
094d152 to
898ffd0
Compare
rvanlaar
reviewed
Jul 11, 2025
db_functions.py
Outdated
| @@ -144,7 +163,7 @@ def insert_fileset( | |||
| return (existing_entry, True) | |||
|
|
|||
| # $game and $key should not be parsed as a mysql string, hence no quotes | |||
| query = f"INSERT INTO fileset (game, status, src, `key`, megakey, `timestamp`) VALUES ({game}, '{status}', '{src}', {key}, {megakey}, FROM_UNIXTIME(@fileset_time_last))" | |||
| query = f"INSERT INTO fileset (game, status, src, `key`, megakey, `timestamp`, set_dat_metadata) VALUES ({game}, '{status}', '{src}', {key}, {megakey}, FROM_UNIXTIME(@fileset_time_last), '{escape_string(set_dat_metadata)}')" | |||
There was a problem hiding this comment.
As I said before, use parameterized queries and don't let the lines get too long.
Where's the formatter?
There was a problem hiding this comment.
Yes, I do use parameterized queries whenever I write a new one. I'll definitely fix the older ones one day. Though I did run the formatter on this file.
db_functions.py
Outdated
| cursor.execute( | ||
| "SELECT status FROM fileset WHERE id = %s", (matched_fileset_id,) | ||
| ) | ||
| status = cursor.fetchone()["status"] | ||
| if status == "detection": | ||
| update_fileset_status(cursor, matched_fileset_id, "partial") | ||
| update_fileset_status(cursor, matched_fileset_id, "parital") |
Thank you, and yes, some of the older queries are still left to be parametrised. |
… handling for column migration.
…ing mismatched files.
…umber of files matched.
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
feab22d to
a303645
Compare
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
3ef16e8 to
26c4fe2
Compare
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
26c4fe2 to
57df340
Compare
ShivangNagta
force-pushed
the
integrity_gsoc_2025_2
branch
from
0d7698a to
d1e8466
Compare
|
Looks fine. Green light from me. |
|
Merging, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.