Only configure the npm registry right before publishing - #191
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to defer npm registry authentication until publishing, avoiding unresolved NODE_AUTH_TOKEN errors during installs.
Changes:
- Removes unnecessary registry configuration from build and pre-publish setup.
- Configures the npm registry immediately before publishing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
.github/workflows/release.yml |
Defers npm registry setup until publishing. |
.github/workflows/build.yml |
Removes unnecessary npm registry configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdivelbiss
marked this pull request as ready for review
August 21, 2026 14:45
sdivelbiss
requested review from
PabloNeirotti,
bverbeken,
latviancoder,
mortendevold and
mroloux
and removed request for
a team
August 21, 2026 14:45
Contributor
Author
|
The build is failing here because of this v6 -> v7 change |
mroloux
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-node v7 no longer exports a placeholder NODE_AUTH_TOKEN
Moves the registry setup to just before the publish step, the same way seatsio-angular does it.