Fix CMakeLists.txt #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Google there is no such CMake function/macro...
Shimmen
changed the title
setup_target_libs CMake function/macro- Require modern CMake version (to avoid deprecation warnings) - Explicitly set c++ version as 20 (as required by the code) - Set appropriate warning levels
…offsetAllocator.hpp`
- Use cstdint integers as the typedefs are not visible here - Use the new path for offsetAllocator.hpp - Remove include of "gfxTestFixture.hpp" as it's not available nor required
Most of this is generated by copilot, so let's see if it works!
because we have the FetchContent backup path.
As suggested by sebbbi#3 (comment), and implemented in tcantenot@7f8218a.
|
I forgot that I had used the main branch as the pull request. All these following commits today were not intended for this pull request, it's just further improvements to the library. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some issues with the CMakeLists.txt build script which I fixed:
setup_target_libs, and CMake (recent version) fails when executing the CMakeLists.txt script. It might be an artefact from the project this was originally created for(?). Either way, this pull request simply removes that line.target_link_libraries(MyTarget offsetAllocator)the header would not be identified. Adding the call totarget_include_directoriesfixes this.Thanks!
// Simon