Skip to content

Clean up tf.debugging.asserts #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Clean up tf.debugging.asserts #881

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2edc8
Clean up tf.debugging.asserts
Oct 11, 2024
8e22a02
Revert "Clean up tf.debugging.asserts"
Oct 15, 2024
143afe5
Re-add logs for new debugging asserts only
Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions trieste/space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,12 +656,20 @@ def one_hot_encoder(self) -> EncoderFunction:

def binary_encoder(x: TensorType) -> TensorType:
# no need to one-hot encode binary categories (but we should still validate)
tf.debugging.Assert(tf.reduce_all((x == 0) | (x == 1)), [tf.constant([])])
tf.debugging.Assert(
tf.reduce_all((x == 0) | (x == 1)),
["Invalid binary values for one-hot encoding:", x],
)
return x

def encoder(x: TensorType) -> TensorType:
flat_x, unflatten = flatten_leading_dims(x)
tf.debugging.assert_equal(flat_x.shape[-1], len(self.tags))
tf.debugging.assert_equal(
flat_x.shape[-1],
len(self.tags),
message="Invalid input for one-hot encoding: "
f"expected {len(self.tags)} tags, got {flat_x.shape[-1]}",
)
columns = tf.split(flat_x, flat_x.shape[-1], axis=1)
encoders = [
(
Expand Down
Loading