-
Notifications
You must be signed in to change notification settings - Fork 232
Support for the exclusion/inclusion of specific data types to be passed through the network. #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
40155cd
to
758496b
Compare
8e9ad03
to
78eea6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions and comments from my first read-through:
78eea6e
to
39ad0a3
Compare
39ad0a3
to
29df05b
Compare
9f3a772
to
647db0b
Compare
Please rebase you PR. |
647db0b
to
08b2692
Compare
08b2692
to
97cad5e
Compare
d33b0f9
to
39d337c
Compare
39d337c
to
8f8d7b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the FederatedRuntime, how does the Aggregator become aware of the allowed or prohibited data types configured in the Jupyter Notebook, especially in a distributed infrastructure setup?
Also, have these scenarios been tested on a distributed infrastructure?
prohibited_data_types and allowed_data_types are class attributes of the Runtime class. These attributes are configured in the aggregator code and can be reviewed in the PR. The scenario has been tested with both Local and Federated runtimes. The FederatedRuntime test is expected to behave equivalently to the distributed setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to individual comments, a valid (close to real world use case) use case / Tutorial for this feature should be demonstrated. This would significantly enhance the understanding of this feature
.../experimental/workflow/FederatedRuntime/101_MNIST/workspace/101_MNIST_FederatedRuntime.ipynb
Outdated
Show resolved
Hide resolved
.../experimental/workflow/FederatedRuntime/101_MNIST/workspace/101_MNIST_FederatedRuntime.ipynb
Show resolved
Hide resolved
8f8d7b5
to
d98b174
Compare
d98b174
to
0b92074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuliasherman, I think this approach would functionally work - although I'd prefer an object-oriented implementation of the allow/prohibit lists (if at all possible).
Here are some additional thoughts and comments:
.../experimental/workflow/FederatedRuntime/101_MNIST/workspace/101_MNIST_FederatedRuntime.ipynb
Show resolved
Hide resolved
.../experimental/workflow/FederatedRuntime/101_MNIST/workspace/101_MNIST_FederatedRuntime.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: yuliasherman <[email protected]>
0b92074
to
69c7f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR, as this seems like the best currently known approach to including/excluding "next" function parameter types. This is likely the solution that will go into 1.9, but I suggest not merging it until the alternative approach has been fully considered.
PS: In parallel, we are exploring a solution where the allow/prohibit lists become Runtime instance variables, and are passed around via the plan.yaml
. This method is conceptually cleaner, but it may be hindered by the limitations of the runtime object itself (esp. from the collaborator side).
Summary
The Workflow API allows object code to be sent today - in part because we want the Workflow API to be more flexible and give model owners / workflow definers the ability to do things outside of horizontal federated learning. But there should be a way to configure a Workflow (at the Runtime level) that ensures that unwanted data types could not be sent. The benefit of this is that when we eventually implement the
SecureFederatedRuntime
, we can attest OpenFL code to ensure that malicious code can not be sent during execution.Type of Change (Mandatory)
Security improvement
Description (Mandatory)
Allow a system to be configured in a way that prohibits/allows passing arguments of chosen types through the FLSpec 'next' function. The new parameters are defined as a Runtime class attributes to be able injecting them into the aggregator object from which the runtime object is not available.
Testing
Manual
Additional Information
The mechanism to terminate a failed experiment in a clean way while using FederatedRuntime yet to be developed.