test: ✅ add publish integration test - #143
Open
martonvago wants to merge 6 commits into
Open
Conversation
martonvago
commented
Aug 18, 2026
|
|
||
| - name: Run Zenodo integration test in the sandbox | ||
| env: | ||
| ZENODO_SANDBOX_TOKEN: ${{ secrets.ZENODO_SANDBOX_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
I created a new sandbox user and got a token for it
martonvago
commented
Aug 18, 2026
| env: | ||
| ZENODO_SANDBOX_TOKEN: ${{ secrets.ZENODO_SANDBOX_TOKEN }} | ||
| run: | | ||
| uv run pytest tests/integration/test_publish.py |
Contributor
Author
There was a problem hiding this comment.
I think it's easier if this is orchestrated in Python (/ Rust I guess) and not in the workflow file or in bash.
martonvago
commented
Aug 18, 2026
| ZenodoCreator( | ||
| name="John Doe", | ||
| affiliation="Test University", | ||
| orcid="0000-0002-1825-0097", |
Contributor
Author
There was a problem hiding this comment.
Josiah Stinkney Carberry is a fictional professor, created as a joke in 1929. He is said to still teach at Brown University, and to be known for his work in "psychoceramics", the supposed study of "cracked pots".
martonvago
commented
Aug 18, 2026
| ## Check deposit directly on Zenodo | ||
| deposit = _check_deposit_on_zenodo(deposit_id, updated_metadata, file_path, client) | ||
| updated_file_size = deposit["files"][0]["filesize"] | ||
| assert updated_file_size > file_size, "New file should be larger than old file." |
Contributor
Author
There was a problem hiding this comment.
As a proxy for checking the contents (which we could do as well by downloading the files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration test for the existing publish command (happy path only).
Closes #75
Needs a thorough review.
Checklist
just run-all