Skip to content

STRATCONN-6039 [Livelike] - new Action #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2025
Merged

Conversation

joe-ayoub-segment
Copy link
Contributor

New Audience compatible Action for Livelike.

Not an actual native Audience, but can be used to sync Audiences to Livelike User Groups.

Testing

Unit tests added.
Partner to test locally, and ensure new endpoint is available.

Copy link
Contributor

github-actions bot commented Jul 16, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: LiveLike, Action Field(s):audience_id,audience_name,timestamp

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.69%. Comparing base (ad9fb70) to head (6e23102).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...stinations/livelike-cloud/syncToUserGroup/utils.ts 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3090      +/-   ##
==========================================
+ Coverage   79.60%   79.69%   +0.09%     
==========================================
  Files        1131     1154      +23     
  Lines       20956    21266     +310     
  Branches     4051     4102      +51     
==========================================
+ Hits        16681    16949     +268     
- Misses       3576     3615      +39     
- Partials      699      702       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment joe-ayoub-segment merged commit 4dd9597 into main Jul 29, 2025
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the livelike-new-action branch July 29, 2025 13:56
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed

harsh-joshi99 pushed a commit that referenced this pull request Jul 31, 2025
* STRATCONN-6039 [Livelike] - new Action

* changes - more to do

* unit tests done

* specifying batch size

* changing max batch size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants