STRATCONN-6051 - [Clay] - New Destination

[ayush-goyal]

Created a new partner action for clay. This includes a page event type that sends data to Clay.

Testing

We've tested this locally and with unit tests.

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [Segmenters] Tested in the staging environment
• [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[joe-ayoub-segment]

Thanks for the PR @ayush-goyal .
Looks pretty straightforward / simple.
Can you tell me what the Clay platform does and why you only want to collect page events instead of other analytics data or user profile data?
Also, are you not interested in collecting page name and properties along with the page() events?

[ayush-goyal]

Thanks for the review @joe-ayoub-segment . Clay wants to integrate with Segment to allow our customers to ingest page visit data from their site. From this, we want to allow them to track visitor data across different pages and identify high-intent prospects for sales.

Could you please further explain what other analytics data might be helpful for our use case? I thought that Page events was the only one necessary as people navigate a site and these events are emitted.

I've updated the code to collect the page properties as well

[joe-ayoub-segment]

hi @ayush-goyal ,

page() events just track some basic details of each page the customer visits. It doesn't capture the interractions on pages though. track() events capture interactions on web pages, mobile apps and other events from back end services.
There's also identify() events which capture details about users (first_name, last_name, phone, etc).

Usually, Partners will collect track() and identify() at a minimum, and optionally page() and screen().

Happy to discuss in person if you'd like. Here's a Calendly link: https://calendly.com/joe_ayoub/30-minute-workshop

Best regards,
Joe

[ayush-goyal]

Thanks for the helpful information on the call today @joe-ayoub-segment , I've made some changes and also included the track event as well. Please take another look when you get a chance

[joe-ayoub-segment]

Looks good to me. Couple of minor comments. I also need to run CI to see if all the tests pass.

[ayush-goyal]

Thanks @joe-ayoub-segment , I updated your comments and removed these types instead

[joe-ayoub-segment]

Hi @ayush-goyal the code is good. However the snapshot test is failing.
Running this should fix it:

yarn cloud test --updateSnapshot

Then commit the change.

[ayush-goyal]

Thanks @joe-ayoub-segment , I just fixed the failing snapshot test

[ayush-goyal]

Thanks @joe-ayoub-segment are you able to merge this PR in? I'm not sure how to fix the failing linter checks

[joe-ayoub-segment]

hi @ayush-goyal the PR is good to go. You can ignore the 2 failing checks. I'll merge if just before I deploy it tomorrow. I'll be in touch once it is live!

[ayush-goyal]

@joe-ayoub-segment great, sounds good thanks!