Skip to content

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 16, 2025

  • Removed @objc from TrackedLifeCycleEvent since it's not exposed to objc.

@bsneed bsneed changed the title Remove objc compatibility since it's not exposed to objc. Remove objc compatibility from TrackedLifecycleEvent since it's not exposed to objc. Sep 16, 2025
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.97%. Comparing base (a4c12ae) to head (e79829c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Segment/Configuration.swift 70.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   71.01%   70.97%   -0.05%     
==========================================
  Files          49       49              
  Lines        4920     4920              
==========================================
- Hits         3494     3492       -2     
- Misses       1426     1428       +2     
Files with missing lines Coverage Δ
Sources/Segment/Configuration.swift 74.57% <70.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsneed bsneed merged commit 34d55c8 into main Sep 16, 2025
7 of 11 checks passed
@bsneed bsneed deleted the bsneed/config_objc branch September 16, 2025 22:06
@bsneed
Copy link
Contributor Author

bsneed commented Sep 16, 2025

will fix ci separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants