json: support omitzero #147
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extemporalgenome
force-pushed
the
json-support-omitzero
branch
2 times, most recently
from
f2a51d3 to
8828185
Compare
modern go tooling requires a version with `go install`.
The constants in particular could have been used, but do not seem that they'd improve readability: these aren't "magic" byte literals, because they're well and widely understood aspects of the JSON syntax.
extemporalgenome
force-pushed
the
json-support-omitzero
branch
from
34b8292 to
5601ab8
Compare
Also set UnsupportedValueError.Value (better stdlib compat).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.