OSS-Fuzz: Add new fuzzer targets X509 processing - #2170
Conversation
|
Closing and reopening to trigger CI after base branch change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2170 +/- ##
========================================
Coverage 82.70% 82.70%
========================================
Files 333 333
Lines 60336 60328 -8
Branches 12578 12872 +294
========================================
- Hits 49900 49895 -5
- Misses 9018 9019 +1
+ Partials 1418 1414 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @arthurscchan for working on it! The new fuzzer doesn't pass CI 😕 |
|
Sorry for dropping that across the weekend. I will fix those CI failed. |
|
I think the 2 CI failed is that the new fuzzer does discover a new issues in the code. I will double check on those. |
@arthurscchan do you think you'll have time to work on it? Should we keep this PR open? |
|
Hi @seladb, I am sorry I am currently side-tracked into other things. I do suggest if you want to make it an official report in OSS-Fuzz, those CI-Fuzz failing could be ignored and allow the new fuzzer to run on oss-fuzz and reported these as real issues. Or I could try and see how I could fix it and create a PR but that may take me some more time on that as I am currently so busy on some other stuff. Sorry for the late reply. |
@arthurscchan I think the right way would be to fix these issues before merging this PR, but if you don't think you'll have time to work on it guess we can ignore them for now, but I'm not sure how to do that 🤔 |
|
ok. I will spend some time to try and fix them. Would you be OK if I directly create PR once I have some fixes? I can do that next week. @seladb |
Sure, please feel free top open a PR for this fixes 👍 |
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
61a7d14 to
c839147
Compare
|
@seladb Unfortunately, the fuzzer once again discover a new problem after fixing the other one. I will try to come up with a fix for the new one next week. |
|
Sorry I am extremely busy this week, I will try to have a fix by the end of next week. |
|
I think after the 2 merged issues, the new fuzzer is good to go now. |
3 participants
This PR adds a new OSS-Fuzz fuzzer targeting X509 processing, together with the fixes of the CMakeList.txt and the OSS-Fuzz build script to accommodate the new fuzzer and the initial seed corpora preparation.