Remove legacy incertae sedis - #333
Open
vangberg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft – #332 needs to be merged first.
We still have the legacy
Name#incertae_sedisfield in the database. In preparation for #173 I would like to remove it to reduce the number of edge cases we need to handle.I have investigated the current state of
Name#incertae_sedisin the production database:There are 16 names with legacy
incertae_sedisset:All 16 records have a placement with either a
parentorincertae_sedis, which can be verified by running the following:I interpret that as it being safe to drop this column from the database.