Skip to content

Fix codebase typos and grammar of error messages #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix codebase typos and grammar of error messages #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d446b
fixed typo of 'reponse'
CCleanerShot Oct 6, 2025
7edfb55
added commas to separate various error fields
CCleanerShot Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/serpapi/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,12 @@ def get(endpoint, decoder = :json, params = {})
# parse JSON response with Ruby standard library
data = JSON.parse(response.body, symbolize_names: symbolize_names)
if data.instance_of?(Hash) && data.key?(:error)
raise SerpApiError, "HTTP request failed with error: #{data[:error]} from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} "
raise SerpApiError, "HTTP request failed with error: #{data[:error]}, from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} "
elsif response.status != 200
raise SerpApiError, "HTTP request failed with response status: #{response.status} reponse: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}"
raise SerpApiError, "HTTP request failed with response status: #{response.status}, response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}"
end
rescue JSON::ParserError
raise SerpApiError, "JSON parse error: #{response.body} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status}"
raise SerpApiError, "JSON parse error: #{response.body}, on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status}"
end

# discard response body
Expand All @@ -244,7 +244,7 @@ def get(endpoint, decoder = :json, params = {})
when :html
# html decoder
if response.status != 200
raise SerpApiError, "HTTP request failed with response status: #{response.status} reponse: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}"
raise SerpApiError, "HTTP request failed with response status: #{response.status}, response: #{data}, on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}"
end

response.body
Expand Down
2 changes: 1 addition & 1 deletion spec/serpapi/client/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
begin
client.send(:get, '/invalid', :html, {})
rescue SerpApi::SerpApiError => e
expect(e.message).to include(/HTTP request failed with response status: 404 Not Found reponse/), "got #{e.message}"
expect(e.message).to include(/HTTP request failed with response status: 404 Not Found response/), "got #{e.message}"
rescue => e
raise("wrong exception: #{e}")
end
Expand Down
Loading