Skip to content

[NO-ISSUE] Rename clazz to inputClass to help the understanding of the DSL#1203

Closed
mcruzdev wants to merge 2 commits intoserverlessworkflow:mainfrom
mcruzdev:refactor-func-dsl
Closed

[NO-ISSUE] Rename clazz to inputClass to help the understanding of the DSL#1203
mcruzdev wants to merge 2 commits intoserverlessworkflow:mainfrom
mcruzdev:refactor-func-dsl

Conversation

@mcruzdev
Copy link
Collaborator

@mcruzdev mcruzdev commented Mar 4, 2026

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

…gnature

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev requested a review from fjtirado as a code owner March 4, 2026 12:40
Copilot AI review requested due to automatic review settings March 4, 2026 12:40
@mcruzdev mcruzdev changed the title Rename clazz to inputClass to help the understanding of the DSL [NO-ISSUE] Rename clazz to inputClass to help the understanding of the DSL Mar 4, 2026
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Fluent Func DSL API documentation and parameter names to improve readability by renaming the commonly-used clazz parameter to inputClass in helper methods.

Changes:

  • Renamed clazz parameters to inputClass across event*, function, consume, and emit* DSL helpers.
  • Updated corresponding Javadoc @param entries to match the new parameter name.
Comments suppressed due to low confidence (1)

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java:524

  • The inferred input type local is named inputClass in function(Function) but inferredInputClass in function(String, Function). Consider using the same name in both overloads (e.g., inputClass) to keep naming consistent and avoid suggesting different semantics.
  public static <T, R> FuncCallStep<T, R> function(String name, Function<T, R> fn) {
    Class<T> inferredInputClass = ReflectionUtils.inferInputType(fn);
    return new FuncCallStep<>(name, fn, inferredInputClass);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mcruzdev
Copy link
Collaborator Author

mcruzdev commented Mar 4, 2026

Closing due a community member asked to work on this issue.

As this issue is simple and does not have high priority I am closing this PR.

@mcruzdev mcruzdev closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants