[NO-ISSUE] Rename clazz to inputClass to help the understanding of the DSL#1203
Closed
mcruzdev wants to merge 2 commits intoserverlessworkflow:mainfrom
Closed
[NO-ISSUE] Rename clazz to inputClass to help the understanding of the DSL#1203mcruzdev wants to merge 2 commits intoserverlessworkflow:mainfrom
mcruzdev wants to merge 2 commits intoserverlessworkflow:mainfrom
Conversation
…gnature Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
approved these changes
Mar 4, 2026
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Fluent Func DSL API documentation and parameter names to improve readability by renaming the commonly-used clazz parameter to inputClass in helper methods.
Changes:
- Renamed
clazzparameters toinputClassacrossevent*,function,consume, andemit*DSL helpers. - Updated corresponding Javadoc
@paramentries to match the new parameter name.
Comments suppressed due to low confidence (1)
experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java:524
- The inferred input type local is named
inputClassinfunction(Function)butinferredInputClassinfunction(String, Function). Consider using the same name in both overloads (e.g.,inputClass) to keep naming consistent and avoid suggesting different semantics.
public static <T, R> FuncCallStep<T, R> function(String name, Function<T, R> fn) {
Class<T> inferredInputClass = ReflectionUtils.inferInputType(fn);
return new FuncCallStep<>(name, fn, inferredInputClass);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Closing due a community member asked to work on this issue. As this issue is simple and does not have high priority I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):