-
Notifications
You must be signed in to change notification settings - Fork 167
feat: baseline run:script, run:container and run:shell to support stdin and argv #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hirenr
wants to merge
10
commits into
serverlessworkflow:main
Choose a base branch
from
hirenr:pr-1128
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−32
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
89d3bf5
Simplification of run:* tasks
hirenr 9a1d6ae
Added Examples
hirenr 0a0152c
Updated examples to add missing stdin in runContainer examples
hirenr fe19df8
Simplification of run:* tasks
hirenr 4b85bb9
Updated with a simpler example!
hirenr c3c89ad
Removed duplicate entries for stdin and arguments in the container co…
hirenr 9c7b979
Updated fixes for Copilot reviews
hirenr 71d1765
Updated example for run-script-example
hirenr 365d7ca
Update dsl-reference.md
cdavernas 0c0ea9a
Update dsl-reference.md
cdavernas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| document: | ||
| dsl: '1.0.2' | ||
| namespace: test | ||
| name: run-container-stdin-and-arguments | ||
| version: '0.1.0' | ||
| do: | ||
| - setInput: | ||
| set: | ||
| message: Hello World | ||
| - runContainer: | ||
| input: | ||
| from: ${ .message } | ||
| run: | ||
| container: | ||
| image: alpine | ||
| command: | | ||
| input=$(cat) | ||
| echo "STDIN was: $input" | ||
| echo "ARGS are $1 $2" | ||
| stdin: ${ . } | ||
| arguments: | ||
| - Foo | ||
| - Bar |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| document: | ||
| dsl: 1.0.2 | ||
| namespace: examples | ||
| name: run-script-with-stdin-and-arguments | ||
| version: 1.0.0 | ||
| do: | ||
| - runScript: | ||
| output: | ||
| as: "${ fromjson }" | ||
hirenr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| run: | ||
| script: | ||
| language: javascript | ||
| stdin: "Hello Workflow" | ||
| environment: | ||
| foo: bar | ||
| arguments: | ||
| - hello | ||
| code: | | ||
| // Reading Input from STDIN | ||
| import { readFileSync } from 'node:fs'; | ||
| const stdin = readFileSync(process.stdin.fd, 'utf8'); | ||
| console.log('stdin > ', stdin) // Output: stdin > Hello Workflow | ||
| // Reading from argv | ||
| const [_, __, arg] = process.argv; | ||
| console.log('arg > ', arg) // Output: arg > hello | ||
| // Reading from env | ||
| const foo = process.env.foo; | ||
| console.log('env > ', foo) // Output: env > bar | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| document: | ||
| dsl: 1.0.2 | ||
| namespace: examples | ||
| name: run-script-with-stdin-and-arguments | ||
hirenr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| version: 1.0.0 | ||
| do: | ||
| - setInput: | ||
| set: | ||
| message: Hello World | ||
| - runShell: | ||
| input: | ||
| from: ${ .message } | ||
| run: | ||
| shell: | ||
| stdin: ${ . } | ||
| command: | | ||
| input=$(cat) | ||
| echo "STDIN was: $input" | ||
| echo "ARGS are $1 $2" | ||
| arguments: | ||
| - Foo | ||
| - Bar | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.