Optimize RecordSetHeader.Order - use static empty instance when there is no order
#354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeiPavlov
changed the title
RecordSetHeader.Order - use station empty intsance when there is no orderRecordSetHeader.Order - use static empty instance when there is no order
snaumenko-st
approved these changes
Feb 12, 2025
| } | ||
| } | ||
|
|
||
| static RecordSetHeader() |
There was a problem hiding this comment.
Is there a way to get rid of this static .ctor and create an empty locked object instantly?
static .ctor has more performance penalties than initializer.
There was a problem hiding this comment.
It is one-time per process penalty, right?
DO has plenty of static constructors.
Of course we can add yet one DirectionCollection constructor just for this purpose
There was a problem hiding this comment.
I can't remember exactly where I read it. It's not a major problem, I believe, but initializers need less checks on type load.
I'll try to figure out more info on this someday :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 150K instances of
DirectionCollection<ColNum> Orderin RAM.And often they are "default" empty