Skip to content

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Feb 21, 2025

  • Use IReadOnlyList<> instead of arrays in tests to make .Contains() in DO expressions compilable.

  • Rename IQueryable<>.LeftJoin() extension to .LeftOuterJoin() to avoid ambiguity with LINQ .LeftJoin() in .NET10. See [API Proposal]: Introduce LeftJoin LINQ operator dotnet/runtime#110292
    Mark .LeftJoin() as [Obsolete] (will be removed after switching to .NET10)

@snaumenko-st
Copy link

snaumenko-st commented Feb 21, 2025

OuterJoin() can be also ambiguous, there are 2 outer joins: left and right. Let's make it LeftOuterJoin() instead

@SergeiPavlov
Copy link
Collaborator Author

Let's make it LeftOuterJoin() instead

done

@SergeiPavlov SergeiPavlov merged commit 0f8bba1 into master-servicetitan Feb 21, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the net10 branch February 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants