Skip to content

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Aug 18, 2025

By some unknown reason Bulk queries (.Update()) prohibit .In(IncludeAlgorithm.ComplexCondition, ...) expressions.
This enforces chunking big lists to conform to SQL's limit on the number of parameters.

In this PR we allow IncludeAlgorithm.TableValuedParameter option if possible
Auto is interpreted as IncludeAlgorithm.TableValuedParameter for long lists

@SergeiPavlov SergeiPavlov changed the title Support Table-Valued parameters in Bulk queries (.Upsate()) Support Table-Valued parameters in Bulk queries (.Update()) Aug 18, 2025
Copy link

@snaumenko-st snaumenko-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also provide some unit tests for this change?

@SergeiPavlov
Copy link
Collaborator Author

Could you please also provide some unit tests for this change?

Sure, 8d53efe

@SergeiPavlov SergeiPavlov merged commit 938450a into master-servicetitan Aug 18, 2025
5 checks passed
@SergeiPavlov SergeiPavlov deleted the BulkTvp branch August 18, 2025 19:00
@botinko
Copy link

botinko commented Aug 18, 2025

That is HUGE finding!

@SergeiPavlov SergeiPavlov mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants