-
Notifications
You must be signed in to change notification settings - Fork 3
Cli UI Patch #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xJepsen
wants to merge
10
commits into
main
Choose a base branch
from
cli-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cli UI Patch #192
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4bfca90
fix: show actual cluster type instead of user-specified
0xJepsen 7c3b7c9
Include delivery type in type information
0xJepsen 06508d4
deno fmt
0xJepsen e119906
deno fmt (#191)
0xJepsen eb4f3f5
Merge branch 'main' of https://github.com/sfcompute/cli
0xJepsen 60ca4fc
fix: show actual cluster type instead of user-specified
0xJepsen 9bcdb9a
Include delivery type in type information
0xJepsen 4396cea
deno fmt
0xJepsen 529f789
deno fmt (#191)
0xJepsen e3d365c
Merge branch 'main' of https://github.com/sfcompute/cli
0xJepsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Warning message uses
zone
variable but should usezone || cluster
since cluster could be set without zone