OSRM dependency injection #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganherlocker
added
behavior
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates sharedstreets-js to make osrm an optional install. This is helpful for deploying to environments with limited resources (raspberry pi, lambda) or difficult compilation targets (redhat, windows) where the functionality that OSRM provides is not needed.
Changelog
?s
@kpwebb this feels almost there, but I wasn't sure how to best instantiate the osrm instance in tests. My guess is that we want to download the cache in the envelope and have the user perform the build step on their own, but want to get your thoughts here.
cc @emilyeros