Refactor json parser #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpwebb Could you please review this when you have time? |
added 2 commits
February 13, 2019 20:16
…mat to correctly parse with parallelism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Gson to parse Json file formats, and create a reliable method to parse Json using a DTO object (so the Java object corresponds to the expected JSON). Gson is one of the most, if not the most, widely used Json parsing libraries, and is very stable and powerful compared to its competitors. It would be nice to eventually convert the existing usage of the JsonIterator to Gson to simplify the code and make it less error-prone/more flexible.