Rework of media importing to handle multiple images + video #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that Twitter converts animated GIFs to MP4s so they are handled as video.
Note that Twitter converts animated GIFs to MP4s so they are handled as video.
rosswintle
commented
Feb 4, 2023
|
|
||
| $post_id = $this->process_tweet($tweet, $this->post_author_id); | ||
|
|
||
| update_post_meta($post_id, '_tweet_id', $tweet->id); |
There was a problem hiding this comment.
This was in process_media for some reason. I've moved it here.
|
Actually... hold off on this. I want to add alt text to images if I can! Shouldn't take long. |
|
Actually - looks like alt text isn't in the export. So don't wait for that. I'll still try and make you a test import though. |
|
OK, here's a folder of test material. This includes:
It does not include a tweet with multiple videos, but there's no reason I can see that that wouldn't work as well. To test this you can just unzip this into the usual location in |
|
@shawnhooper any thoughts on merging in this? |
|
@timnolte I sure do! I just haven't had time to test it. I'll try to merge it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17
This is a fairly major refactor of media handling. It enables:
It saves multiple media items using meta keys:
_tweet_media_x_tweet_media_type_xAll media are added to the Tweet using
imgorvideotags.I've tried to keep to the filtering conventions you have used.
It attempts some optimisation by only updating the post once when processing media for a post, and by changing how files are looped through. Specifically:
I did not implement a
--import-mediaflag - this can be done another time.I bumped the version number and updated the readme.txt
This now VERY NEARLY successfully processes my entire Tweet history and media. There is one media not found error. I've not investigated this yet.
I'll leave this with you for review. I shall attempt to provide a minimal subset of my import for testing purposes, if that's helpful? But it's too late to do that today.
Thanks! Hope you like the improvements!