Skip to content

Conversation

@Aaditya-Chunekar
Copy link
Contributor

Added SEO Forum (Forum for discussing all things SEO)

@github-actions
Copy link
Contributor

Automatic validation of changes

Target F+ Check F- Check
SEOForum ✔️   Pass ✔️   Pass

@Aaditya-Chunekar
Copy link
Contributor Author

Aaditya-Chunekar commented Oct 22, 2025

@ppfeister Hey, sorry for the tag — could you please take a look and merge these PRs whenever time permits?
#2705(current - SEO Forum),
#2709(topmate.io), and
#2710(Arduino Forum, HackerSploit Community, n8n Community)
They’re part of Hacktoberfest, so just trying to get them in before the deadline.
Appreciate your time and help!

@Aaditya-Chunekar Aaditya-Chunekar changed the title Add SEO Forum Support hacktoberfest: Add SEO Forum Support Oct 23, 2025
@ppfeister
Copy link
Member

ppfeister commented Oct 23, 2025

LGTM. If you don't mind, could you clean up the commit history with the following? Not ideal having so many commits per minor change. Muddies the log.

Added the accepted tag so it counts as of this moment, despite pending:

(assuming master is up to date and your data.json doesn't have random extra changes)

git reset $(git merge-base master HEAD)
git add sherlock_project/resources/data.json
git commit -m "feat: add SEOForum"
git push --force-with-lease

Recommend saving elsewhere if unsure. Let me know if you have any issues.

@github-actions
Copy link
Contributor

Automatic validation of changes

Target F+ Check F- Check
SEOForum ✔️   Pass ✔️   Pass

@github-actions
Copy link
Contributor

Automatic validation of changes

Target F+ Check F- Check
SEOForum ✔️   Pass ✔️   Pass

@Aaditya-Chunekar
Copy link
Contributor Author

Aaditya-Chunekar commented Oct 24, 2025

Thanks a lot for the review! This is my first contribution, and I got a bit messy with commits while experimenting.
Updated all 3 PRs as per your suggestion. Appreciate the help!

@ppfeister ppfeister merged commit 8675178 into sherlock-project:master Oct 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants