#87 - testing-fab - #88
Conversation
There was a problem hiding this comment.
Pull request overview
Adds project terminology definitions for the planned “Testing FAB” feature so Consumer applications and the Library share consistent language when documenting/implementing the FAB and its widgets.
Changes:
- Introduces standardized terms: Testing FAB, Action Widget, Select Query Param Widget, Custom Component Widget.
- Documents behavioral concepts (URL-authoritative selection, opt-in provisioning, Consumer-owned activation safety).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mumenthalers
left a comment
There was a problem hiding this comment.
@copilot fix comments. make use of the mcp to get info
Addressed in commit I updated the Testing FAB provider API and rendering initializer, migrated the component to modern Angular control flow + native popover, added hard-reload support for select query-param widgets, removed custom-component |
|
@copilot fix fox |
Fixed in commit |
|
@copilot fix formatting (prettier). also make sure lint, test, build will run |
Addressed in commit I applied Prettier formatting fixes to the 4 failing Testing FAB files. I also checked Actions via MCP: the new workflow run for this commit is |
|
@copilot now linting failed. you know that you can execute those commands yourself? and when commitin it should actually be run by husky, right? |
Fixed in commit I checked the failing CI lint job via MCP logs, reproduced the issue context locally as far as this sandbox allows, and fixed the reported lint violations in the Testing FAB files. And yes: commits should run Husky pre-commit here ( |
5509c49 to
4da425d
Compare
4da425d to
eb7cad5
Compare
8fe92f7 to
8d0b3c8
Compare
b7cec1a to
c7977df
Compare
|
@copilot address the open comments |
Addressed in commit I fixed the remaining active review comments by naming the testing-fab injection token, updating the |
d5f8e57 to
8c79c05
Compare
Implements a configurable Testing FAB in
@shiftcode/ngx-componentsinstead of only documenting terminology.Changes Made
TestingFabComponentas a floating, always-on-top FAB with an expandable control panel.provideTestingFab(...)for opt-in provisioning.libs/components/src/public-api.ts.URL,HTML) inCONTEXT.md.provideTestingFab(...)to accept either a static widget config or a factory (ValueOrFactorypattern).sc-testing-fabautomatically viacreateComponent(...)andprovideEnvironmentInitializer(...).inputssupport).hardReloadsupport for select-query-param widgets to optionally update the URL and reload directly.@for,@switch,@let) and switched toggle behavior to nativepopover.inset,margin,size,border-radius, background/foreground colors, and icon URL with default Shiftcode logo).