Support UUIDs in PK stored in binary form #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix of broken ORM: doctrine/orm#12042 |
JanTvrdik
approved these changes
Aug 7, 2025
|
Another ORM bug detected by our improved testcases: doctrine/orm#12130 |
JanTvrdik
reviewed
Aug 15, 2025
| use Doctrine\ORM\Mapping\MappedSuperclass; | ||
|
|
||
| #[MappedSuperclass] | ||
| abstract class TestEntityWithCustomPrimaryKey |
There was a problem hiding this comment.
This is simple enough, I think it would be lot better to inline it back to reduce code complexity.
JanTvrdik
reviewed
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
Invalid utf8mb4 character string(assumingutf8mb4connection encoding)Character not in repertoire: 7 ERROR: invalid byte sequence for encoding "UTF8": 0x8d)