Implement simple caching option #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shosca
force-pushed
the
caching
branch
2 times, most recently
from
0391afc to
d9ed40d
Compare
Pull Request Test Coverage Report for Build 1087
💛 - Coveralls |
miki725
reviewed
Jan 30, 2019
miki725
reviewed
Jan 30, 2019
miki725
reviewed
Jan 30, 2019
miki725
reviewed
Jan 30, 2019
| db = databases.get("test") | ||
|
|
||
|
|
||
| class DummyCache(object): |
There was a problem hiding this comment.
maybe simple in-memory variant in sorcery itself? are there other libs there which can plug and play with this interface?
There was a problem hiding this comment.
dogpile.cache should work ootb
There was a problem hiding this comment.
cool. then prolly a good idea to add to somewhere
miki725
reviewed
Jan 30, 2019
| @@ -0,0 +1,75 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
maybe add docstring that this is heavily inspired by https://docs.sqlalchemy.org/en/latest/_modules/examples/dogpile_caching/caching_query.html?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly from sqlalchemy dogpile caching recipe with some tweaks